Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: split up test_concat.py #37243 - follows up #37368

Merged
merged 1 commit into from
Oct 23, 2020

Conversation

kamilt5
Copy link
Contributor

@kamilt5 kamilt5 commented Oct 23, 2020

  • created test_datetime.py and
    split datetime/timezone/period related tests
  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

* created test_datetime.py and
  split datetime/timezone/period related tests
@kamilt5
Copy link
Contributor Author

kamilt5 commented Oct 23, 2020

This is first part, I have to create also test_categorical, test_empty, test_invalid, test_sort. I have 3 classes, TestDatetimeConcat, TestTimezoneConcat and TestPeriodConcat, leaving here TestPeriodConcat is probably best decision, because it have only 50 lines. I wasn't able to find more functions to put into it.

@jreback jreback added Reshaping Concat, Merge/Join, Stack/Unstack, Explode Testing pandas testing functions or related to the test suite labels Oct 23, 2020
@jreback jreback added this to the 1.2 milestone Oct 23, 2020
@jreback jreback merged commit 9fd30b7 into pandas-dev:master Oct 23, 2020
@jreback
Copy link
Contributor

jreback commented Oct 23, 2020

thanks @laffite56

yep this looks good, keep em coming. (you an break out period is ok too)

JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Oct 26, 2020
kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reshaping Concat, Merge/Join, Stack/Unstack, Explode Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants