Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Set timeoffset as the window parameter #37407

Merged
merged 4 commits into from
Oct 26, 2020

Conversation

gabriellm1
Copy link
Contributor

Hi guys, just added tests for issue #28266. I'm participating in the Hacktoberfest event and would much appreciate it if someone put the label ‘hacktoberfest-accepted’ on this PR. Any modification needed just hit me up :)

@pep8speaks
Copy link

pep8speaks commented Oct 25, 2020

Hello @gabriellm1! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-10-26 01:23:03 UTC

@gabriellm1 gabriellm1 changed the title Test added for issue #28266 TST: Set timeoffset as the window parameter Oct 25, 2020
@mroeschke mroeschke added hacktoberfest-accepted Testing pandas testing functions or related to the test suite labels Oct 26, 2020
@mroeschke mroeschke added this to the 1.2 milestone Oct 26, 2020
@mroeschke mroeschke merged commit 8da70fc into pandas-dev:master Oct 26, 2020
@mroeschke
Copy link
Member

Thanks @gabriellm1

JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Oct 26, 2020
@TusakaRin
Copy link

Thanks!

kesmit13 pushed a commit to kesmit13/pandas that referenced this pull request Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

set timeoffset as the window parameter doesn't work for rolling corr function
4 participants