Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN: remove something.xlsx #37857

Merged
merged 1 commit into from
Nov 15, 2020
Merged

CLN: remove something.xlsx #37857

merged 1 commit into from
Nov 15, 2020

Conversation

twoertwein
Copy link
Member

test_register_writer in pandas/tests/io/excel/test_writers.py wasn't expecting that something.xls and something.xlsx will ever be created.

Since #37639, ExcelWriter opens the file which will create it.

@twoertwein twoertwein mentioned this pull request Nov 15, 2020
Merged
@jbrockmendel
Copy link
Member

LGTM ping on green

@twoertwein
Copy link
Member Author

twoertwein commented Nov 15, 2020 •
edited
Loading

@jbrockmendel green'ish

@jbrockmendel jbrockmendel merged commit 5c4d0aa into pandas-dev:master Nov 15, 2020
@jbrockmendel
Copy link
Member

thanks @twoertwein

@twoertwein twoertwein deleted the excel branch November 15, 2020 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twoertwein @jbrockmendel