Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compat: sqlalchemy deprecations #40471

Merged
merged 1 commit into from
Mar 16, 2021
Merged

compat: sqlalchemy deprecations #40471

merged 1 commit into from
Mar 16, 2021

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

@jbrockmendel jbrockmendel mentioned this pull request Mar 16, 2021
Merged
jreback
jreback reviewed Mar 16, 2021
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine but comment on the way u r getting the version

pandas/io/sql.py
@@ -77,6 +78,16 @@ def _is_sqlalchemy_connectable(con):
return False


def _gt14() -> bool:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we have a test decorator for this type of thing right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have a decorator to skip a test depending on the version, not to re-write the test

@jreback jreback added this to the 1.2.4 milestone Mar 16, 2021
@jreback jreback added IO SQL to_sql, read_sql, read_sql_query Dependencies Required and optional dependencies labels Mar 16, 2021
@jreback
Copy link
Contributor

jreback commented Mar 16, 2021

ok i think we should prob backport this any objections?

@jreback jreback modified the milestones: 1.2.4, 1.3 Mar 16, 2021
@jreback jreback merged commit bbab54a into pandas-dev:master Mar 16, 2021
@jreback
Copy link
Contributor

jreback commented Mar 16, 2021

cc @simonjayhawkins its possible may need to backport things like this for 1.2.4

@jbrockmendel jbrockmendel deleted the ci-sa branch March 16, 2021 20:33
@jorisvandenbossche
Copy link
Member

Yeah, I think this might be useful to backport

@jorisvandenbossche jorisvandenbossche modified the milestones: 1.3, 1.2.4 Mar 16, 2021
This was referenced Mar 16, 2021
Closed
Closed
@simonjayhawkins
Copy link
Member

@meeseeksdev backport 1.2.x

@lumberbot-app

This comment has been minimized.

Sign in to view
simonjayhawkins pushed a commit to simonjayhawkins/pandas that referenced this pull request Mar 17, 2021
@jbrockmendel @simonjayhawkins
Backport PR pandas-dev#40471: compat: sqlalchemy deprecations
f7731e2
@simonjayhawkins simonjayhawkins mentioned this pull request Mar 17, 2021
Merged
simonjayhawkins added a commit that referenced this pull request Mar 17, 2021
@simonjayhawkins @jbrockmendel
Backport PR #40471: compat: sqlalchemy deprecations (#40481)
0c1c8c8 
Co-authored-by: jbrockmendel <jbrockmendel@gmail.com>
@jrbourbeau jrbourbeau mentioned this pull request Mar 17, 2021
Closed
@zzzeek zzzeek mentioned this pull request May 4, 2021
Closed
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
@jbrockmendel @JulianWgs
compat: sqlalchemy deprecations (pandas-dev#40471)
2f8919c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Dependencies Required and optional dependencies IO SQL to_sql, read_sql, read_sql_query
Projects
None yet
Milestone
1.2.4
Development

Successfully merging this pull request may close these issues.
4 participants
@jbrockmendel @jreback @jorisvandenbossche @simonjayhawkins