TST: Skip leaky test on Python 3.10 #43910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @lithomas1! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-10-08 14:41:15 UTC |
|
@github-actions pre-commit |
lithomas1
changed the title
|
@github-actions pre-commit |
lithomas1
added
Python 3.10
Testing
jreback
reviewed
Oct 7, 2021
|
@github-actions pre-commit |
|
We need to target 1.3.4 since we've already released Python 3.10 wheels, which means we've committed to Python 3.10 support in 1.3.x. We cannot commit to Python 3.10 support if we allow failure on the CI build. This PR takes the CI build out of allow failure by resolving the leaky test causing flaky, cryptic errors. |
|
sounds good |
jbrockmendel
reviewed
Oct 8, 2021
|
LGTM |
|
thanks @lithomas1 very nice |
|
@meeseeksdev backport 1.3.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Oct 9, 2021
|
Something went wrong ... Please have a look at my logs. |
lithomas1
added a commit
that referenced
this pull request
Oct 9, 2021
Co-authored-by: Thomas Li <47963215+lithomas1@users.noreply.github.com>
gasparitiago
pushed a commit
to gasparitiago/pandas
that referenced
this pull request
Oct 9, 2021
rhshadrach
pushed a commit
to rhshadrach/pandas
that referenced
this pull request
Oct 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test seems to be leaking on Python 3.10, causing subsequent tests to fail with a cryptic and flaky error. Let's skip it.
This unblocks official Python 3.10 support.
I am not fixing the test since my first attempt at fixing the leakiness failed and I don't understand and don't have time to fix the problem.
If this works, we can revert #41990.