Issue 21932: Added Regression Test for index of pivot_table on empty table #52809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MirijaH
changed the title
rhshadrach
added
Reshaping
phofl
reviewed
Apr 21, 2023
pandas/tests/reshape/test_pivot.py
Outdated
| def test_pivot_table_empty_dataframe_correct_index(self): | ||
| # GH 21932 | ||
| df = DataFrame([], columns=["a", "b", "value"]) | ||
| pivot = df.pivot_table(index="a", columns="b", values="value", |
There was a problem hiding this comment.
Can you run pre-commit? This is formatted incorrectly
There was a problem hiding this comment.
thx for the head up, done :)
pandas/tests/reshape/test_pivot.py
Outdated
| pivot = df.pivot_table(index="a", columns="b", values="value", aggfunc="count") | ||
|
|
||
| expected = pd.Index([], dtype="object", name="b") | ||
| tm.assert_index_equal(pivot.columns, expected) |
There was a problem hiding this comment.
I'd suggest you run pre-commit, please check the contributing guide for how to do that
There was a problem hiding this comment.
thx for the head up, done :)
phofl
approved these changes
Apr 22, 2023
|
thx @MirijaH |
Rylie-W
pushed a commit
to Rylie-W/pandas
that referenced
this pull request
May 19, 2023
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@phofl, @noatamir, @jorisvandenbossche and @MarcoGorelli