Issue 52827: Added xfail for pyarrow int64 rounding #52858
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szczekulskij
changed the title
phofl
reviewed
Apr 23, 2023
| with tm.ensure_clean("__tmp_to_csv_from_csv3__") as path: | ||
| # GH 52827 | ||
| pytest.importorskip("pyarrow") | ||
| pd.DataFrame({"x": ["1372636858620000589"]}).to_csv(path, index=False) |
There was a problem hiding this comment.
Please avoid roundtripping through csv
There was a problem hiding this comment.
Thanks for the feedback.
Updated - checked locally and it throws the right error:
pyarrow.lib.ArrowInvalid: Integer value 1372636858620000589 not in range: -9007199254740992 to 9007199254740992
|
Hi @phofl, can I ask for a second review ? |
|
Feel free to reopen when you have time to circle back here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an entry in the latestdoc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.