Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: overriden methods of subclasses of Styler are not called during … #52868

Conversation

YifanChao
Copy link

…rendering #52728

BUG: overriden methods of subclasses of Styler are not called during rendering #52728

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

…rendering pandas-dev#52728

BUG: overriden methods of subclasses of Styler are not called during rendering pandas-dev#52728
@phofl
Copy link
Member

phofl commented Apr 23, 2023

Please don't open a PR for every change you have to do on this branch. You can simply push to this branch and the ci will rerun

…pandas-dev#52868

BUG: overriden methods of subclasses of Styler are not called during … pandas-dev#52868
@attack68
Copy link
Contributor

attack68 commented Apr 23, 2023

The underlying issue was labelled as "good first issue" and had already been taken and assigned to @nicklausroach. It is not respectful towards the community to ignore that and push your own PR without commenting in the issue.

If he does not submit a PR within a few days it is possible to ask him if he would not mind reassigning it to you.

@YifanChao
Copy link
Author

Sorry, I'm a new user who's just testing on these. Since it didn't pass the test. I'll stop there.

@attack68
Copy link
Contributor

You can use the search function for issues with 'label:"good first issue"', and this will usually yield some good results that are not taken which are worthwhile trying.

@phofl
Copy link
Member

phofl commented Apr 23, 2023

Closing then

@phofl phofl closed this Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants