Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: convert_dtypes ingoring convert keywords for pyarrow backend #52872

Merged
merged 14 commits into from
Apr 27, 2023
Merged

BUG: convert_dtypes ingoring convert keywords for pyarrow backend #52872

merged 14 commits into from
Apr 27, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented Apr 23, 2023

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

cc @mroeschke
This seems buggy, we should still respect the keywords

@phofl phofl added Dtype Conversions Unexpected or buggy dtype conversions Arrow pyarrow functionality labels Apr 23, 2023
@phofl phofl added this to the 2.0.1 milestone Apr 23, 2023
@phofl phofl added the Bug label Apr 23, 2023
@datapythonista datapythonista modified the milestones: 2.0.1, 2.0.2 Apr 23, 2023
mroeschke
mroeschke reviewed Apr 24, 2023
View reviewed changes
pandas/core/dtypes/cast.py Outdated
or (convert_string and is_string_dtype(inferred_dtype))
or (
inferred_dtype.kind not in "iufcb"
and not is_string_dtype(inferred_dtype)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here potentially

phofl and others added 5 commits April 24, 2023 20:47
@phofl @mroeschke
Update doc/source/whatsnew/v2.0.1.rst
5ba8147 
Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
@phofl @mroeschke
Update pandas/core/dtypes/cast.py
e5ec669 
Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
@phofl
Fix
26cc20e
@phofl
Merge remote-tracking branch 'upstream/main' into 52871
ad40501
@phofl
Move
67484e8
@mroeschke
Copy link
Member 

mypy.....................................................................Failed
- hook id: mypy
- duration: 163.23s
- exit code: 1

pandas/core/dtypes/cast.py:1110: error: Item "str" of "Union[str, Any, dtype[Any], ExtensionDtype]" has no attribute "kind"  [union-attr]
pandas/core/dtypes/cast.py:1111: error: Item "str" of "Union[str, Any, dtype[Any], ExtensionDtype]" has no attribute "kind"  [union-attr]
pandas/core/dtypes/cast.py:1112: error: Item "str" of "Union[str, Any, dtype[Any], ExtensionDtype]" has no attribute "kind"  [union-attr]
pandas/core/dtypes/cast.py:1115: error: Item "str" of "Union[str, Any, dtype[Any], ExtensionDtype]" has no attribute "kind"  [union-attr]
Found 4 errors in 1 file (checked 1417 source files)

@phofl
Copy link
Member Author

phofl commented Apr 25, 2023

thx fixed

@mroeschke
Copy link
Member

Merge conflict otherwise looks good

@phofl phofl merged commit fe247ea into pandas-dev:main Apr 27, 2023
@phofl phofl deleted the 52871 branch April 27, 2023 12:27
@meeseeksmachine meeseeksmachine mentioned this pull request Apr 27, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Apr 27, 2023
@phofl @meeseeksmachine
Backport PR pandas-dev#52872: BUG: convert_dtypes ingoring convert ke…
f208282 
…ywords for pyarrow backend
phofl added a commit that referenced this pull request Apr 27, 2023
@meeseeksmachine @phofl
Backport PR #52872 on branch 2.0.x (BUG: convert_dtypes ingoring conv…
79abb44 
…ert keywords for pyarrow backend) (#52959)

Backport PR #52872: BUG: convert_dtypes ingoring convert keywords for pyarrow backend

Co-authored-by: Patrick Hoefler <61934744+phofl@users.noreply.github.com>
topper-123 pushed a commit to topper-123/pandas that referenced this pull request Apr 27, 2023
@phofl @topper-123
BUG: convert_dtypes ingoring convert keywords for pyarrow backend (pa…
c536f60 
…ndas-dev#52872)
topper-123 pushed a commit to topper-123/pandas that referenced this pull request May 7, 2023
@phofl @topper-123
BUG: convert_dtypes ingoring convert keywords for pyarrow backend (pa…
c5d16a2 
…ndas-dev#52872)
Rylie-W pushed a commit to Rylie-W/pandas that referenced this pull request May 19, 2023
@phofl
BUG: convert_dtypes ingoring convert keywords for pyarrow backend (pa…
b72cb7b 
…ndas-dev#52872)
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
@phofl
BUG: convert_dtypes ingoring convert keywords for pyarrow backend (pa…
6f8e79d 
…ndas-dev#52872)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke left review comments

Assignees
No one assigned
Labels
Arrow pyarrow functionality Bug Dtype Conversions Unexpected or buggy dtype conversions
Projects
None yet
Milestone
2.0.2
Development

Successfully merging this pull request may close these issues.
3 participants
@phofl @mroeschke @datapythonista