ENH: add ExtensionArray._explode method; adjust pyarrow extension for use of new interface
#54834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douglasdavis
force-pushed
the
explode-method-extension-array
branch
from
c71cafb
to
cec3ff7
Compare
mroeschke
reviewed
Aug 29, 2023
mroeschke
reviewed
Aug 29, 2023
mroeschke
added
the
ExtensionArray
Error: /home/runner/work/pandas/pandas/pandas/core/arrays/base.py:1928:GL01:pandas.api.extensions.ExtensionArray._explode:Docstring text (summary) should start in the line immediately after the opening quotes (not in the same line, or leaving a blank line in between)
Error: /home/runner/work/pandas/pandas/pandas/core/arrays/base.py:1928:GL02:pandas.api.extensions.ExtensionArray._explode:Closing quotes should be placed in the line after the last text in the docstring (do not close the quotes in the same line as the text, or leave a blank line between the last text and the quotes)
Error: /home/runner/work/pandas/pandas/pandas/core/arrays/base.py:1928:GL03:pandas.api.extensions.ExtensionArray._explode:Double line break found; please use only one blank line to separate sections or paragraphs, and do not leave blank lines at the end of docstrings
Error: /home/runner/work/pandas/pandas/pandas/core/arrays/base.py:1928:SA03:pandas.api.extensions.ExtensionArray._explode:Description should be capitalized for See Also "Series.explode" reference
Error: /home/runner/work/pandas/pandas/pandas/core/arrays/base.py:1928:EX01:pandas.api.extensions.ExtensionArray._explode:No examples section found |
Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
douglasdavis
force-pushed
the
explode-method-extension-array
branch
from
c05688e
to
b1b6cb5
Compare
mroeschke
approved these changes
Aug 31, 2023
|
Could you fix the merge conflict? I think this should be good to merge after that |
|
yep, fixed! (CI failures look unrelated; spelling in a file untouched but this PR and an installation issue associated with BLAS) |
mroeschke
approved these changes
Sep 18, 2023
|
Thanks @douglasdavis |
hedeershowk
pushed a commit
to hedeershowk/pandas
that referenced
this pull request
Sep 20, 2023
…or use of new interface (pandas-dev#54834) * add ExtensionArray._explode method; adjust pyarrow extension for use * black * add to whatsnew 2.1.0 * pre-commit fix * add _explode to docs * Update pandas/core/arrays/arrow/array.py Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com> * switch whatsnew files * adjust docstring * fix docstring --------- Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_explodea method of theExtensionArrayinterface #54833doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.