Adjust tests in array folder for new string option #56188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Testing
|
cc @mroeschke gentle ping |
mroeschke
reviewed
Dec 8, 2023
pandas/core/algorithms.py
Outdated
| @@ -929,10 +931,13 @@ def value_counts_internal( | |||
|
|
|||
| # For backwards compatibility, we let Index do its normal type | |||
| # inference, _except_ for if if infers from object to bool. | |||
| idx = Index(keys) | |||
| idx = Index(keys, dtype=input_dtype if input_dtype != "float16" else None) | |||
There was a problem hiding this comment.
Should these changes not be here after your comments in #56187?
There was a problem hiding this comment.
oh very good point, forgot the revert. thx. does
This reverts commit f570a4f
mroeschke
reviewed
Dec 9, 2023
| @@ -932,7 +932,10 @@ def value_counts_internal( | |||
| idx = Index(keys) | |||
| if idx.dtype == bool and keys.dtype == object: | |||
| idx = idx.astype(object) | |||
| elif idx.dtype != keys.dtype: | |||
| elif ( | |||
| idx.dtype != keys.dtype # noqa: PLR1714 # # pylint: disable=R1714 | |||
There was a problem hiding this comment.
Just confirming this change isn't related to your referenced, closed PR right?
There was a problem hiding this comment.
No this is fine, this is the infer_string inference, which will still happen
mroeschke
approved these changes
Dec 9, 2023
|
Thanks @phofl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sits on top of #56187