DOC: remove concat dict sortedness statement #58518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
May 2, 2024
pandas/core/reshape/concat.py
Outdated
| @@ -171,7 +171,7 @@ def concat( | |||
| Parameters | |||
| ---------- | |||
| objs : an iterable or mapping of Series or DataFrame objects | |||
| If a mapping is passed, the sorted keys will be used as the `keys` | |||
| If a mapping is passed, the unsorted keys will be used as the `keys` | |||
There was a problem hiding this comment.
Suggested change
| If a mapping is passed, the unsorted keys will be used as the `keys` | |
| If a mapping is passed, the keys will be used as the `keys` |
mroeschke
approved these changes
May 2, 2024
|
Thanks @er-eis |
|
@mroeschke absolutely, thank you for the quick review! |
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
* DOC: remove concat dict sortedness statement * DOC: simplify objs order comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pd.concatdescription of ordering when passing a mapping is unclear #58516