Fix insertion of None value in MultiIndex #59069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
chaoyihu
force-pushed
the
multiindex-insert-na
branch
from
b026334
to
efff668
Compare
yuanx749
reviewed
Jun 24, 2024
doc/source/whatsnew/v3.0.0.rst
Outdated
| @@ -543,6 +543,7 @@ MultiIndex | |||
| ^^^^^^^^^^ | |||
| - :func:`DataFrame.loc` with ``axis=0`` and :class:`MultiIndex` when setting a value adds extra columns (:issue:`58116`) | |||
| - :meth:`DataFrame.melt` would not accept multiple names in ``var_name`` when the columns were a :class:`MultiIndex` (:issue:`58033`) | |||
| - :meth:`MultiIndex.insert` would not insert None value correctly at unified location of index -1 (:issue:`59003`) | |||
There was a problem hiding this comment.
Suggested change
| - :meth:`MultiIndex.insert` would not insert None value correctly at unified location of index -1 (:issue:`59003`) | |
| - :meth:`MultiIndex.insert` would not insert ``None`` value correctly at unified location of index -1 (:issue:`59003`) |
nitpick
mroeschke
reviewed
Jun 24, 2024
pandas/tests/test_multilevel.py
Outdated
| def test_multiindex_insert_level_with_na(self): | ||
| # GH 59003 | ||
| indices = [["one"], ["a"], ["yes"]] | ||
| df = DataFrame([0], index=indices).T |
There was a problem hiding this comment.
Could you construct this without .T?
mroeschke
reviewed
Jun 24, 2024
pandas/tests/test_multilevel.py
Outdated
| df = DataFrame([0], index=indices).T | ||
| df["one", None, "yes"] = 1 | ||
| expected = DataFrame([1], index=Index(["yes"])).T | ||
| tm.assert_frame_equal(df["one"][None], expected) |
There was a problem hiding this comment.
Could you test this without doing a chained indexing?
mroeschke
reviewed
Jun 24, 2024
pandas/tests/test_multilevel.py
Outdated
| df["one", None, "yes"] = 1 | ||
| expected = DataFrame([1], index=Index(["yes"])).T | ||
| tm.assert_frame_equal(df["one"][None], expected) | ||
| df["one", np.nan, "yes"] = 1 |
There was a problem hiding this comment.
Can you use pytest.mark.parametrize with np.nan and None
There was a problem hiding this comment.
Cool! I tried to stay close to the reproducible code example in the linked issue, but it's really not necessary. Now the test case looks more concise and to the point. Thanks for the suggestions.
mroeschke
added
Missing-data
mroeschke
approved these changes
Jun 25, 2024
|
Thanks @chaoyihu |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/v3.0.0.rstfile if fixing a bug or adding a new feature.