BUG: unstack fails in PeriodIndex #7041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -458,6 +458,7 @@ Bug Fixes | |||
| - Bug in timeseries-with-frequency plot cursor display (:issue:`5453`) | |||
| - Bug surfaced in groupby.plot when using a ``Float64Index`` (:issue:`7025`) | |||
| - Stopped tests from failing if options data isn't able to be downloaded from Yahoo (:issue:`7034`) | |||
| - Bug in ``unsatck`` raises ``ValueError`` when ``MultiIndex`` contains ``PeriodIndex`` (:issue:`4342`) | |||
|
did anything change because of the sorting change? |
|
@sinhrks fyi, in general ping me when you think something is ready for merging (esp if its marked for 0.14). try to make green! if its not, ok to ping as well and will take a look |
|
Sorting change only affects to
|
|
ok; looking at this code, I think you can define then just do the test |
|
ok, i think you can rebase this and then good? |
|
or close after #7090? |
|
Should be rebased, I will finish it soon. |
|
@jreback Rebased, and get green. |
jreback
added a commit
that referenced
this pull request
May 10, 2014
BUG: unstack fails in PeriodIndex
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4342.
Also changed
CategoricalandPeriodIndex.factorizeto make index sorted like other indexes do.