-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple bibliographies per topic (etc.) #8
base: main
Are you sure you want to change the base?
Conversation
The full list of changes is: - Support multiple bibliographies per topic, i.e., in the 'bibliography' metadata, allow topic entries to be list-valued - Support the same topic structure for the 'references' metadata item, so can override references per topic - Ignore duplicate references, i.e. if the same reference exists in multiple topics (the first one encountered is used, but this is not satisfactory because the topic processing order is indeterminate). Note that something had to be done here, because these duplicates would have the same ids and therefore would be ambiguous - Take some changes from the diverged multiple-bibliographies repo, notably don't use utils.citeproc() because it doesn't have a 'quiet' option (which is needed for the second pass) - Fix an undefined 'orig_bib' bug (that probably caused no problems) - Add filters to renumber citations in the case where they're referenced by citation number. These filters won't do anything in other cases, but nevertheless probably shouldn't be here
@tarleb (and others), any thoughts on this PR? Thanks. |
What I like about this PR is that reference numbers do not "reset" between bibliographies (see #6). This PR generally works, with a couple caveats:
|
Sorry for the delay in replying. I suspect that both of your caveats can be addressed. I'll take a look. Re your caveat 1 please note that there's already an attempt to address this problem, but it doesn't support ranges. |
Very cool! Could you split this up into separate PRs? Things that I'm definitely in favor of:
I'm a bit skeptical towards others:
|
@tarleb I'll take a look. And @jerome-white apologies for not doing what I said I'd do (perhaps on this upcoming iteration...). |
Note: I'm creating this PR for discussion. I fully expect that further changes might be necessary before merging it.
The full list of changes is:
Also: