Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce latex image size #24

Merged
merged 2 commits into from
Mar 7, 2019
Merged

reduce latex image size #24

merged 2 commits into from
Mar 7, 2019

Conversation

svenevs
Copy link
Member

@svenevs svenevs commented Mar 5, 2019 •
edited
Loading

New PR (supersedes #14) for CI to run now that we have tests!

Fixes #5.

  • verify all tests succeed / the hidden tex dependencies are found (as best as we can find them)
  • delete original reduce-latex-size branch once this merges (rebase / merge creates lots of conflicts, easier to keep around for track record until not needed)

@svenevs svenevs mentioned this pull request Mar 5, 2019
Closed
3 tasks
@tarleb tarleb mentioned this pull request Mar 5, 2019
Closed
@svenevs
reduce latex image size
38e440a
@svenevs
install missing packages, modularize for cache benefits
98c0f9d 
- install missing packages as identified by tests
- install packages for graphicx, grffile, and longtable
- move tlmgr package installs to separate script so that
  install-tl does not rerun every time.
- make package listings alphabetical for consistency
@svenevs svenevs requested a review from tarleb March 6, 2019 16:21
@svenevs
Copy link
Member Author

svenevs commented Mar 6, 2019

ok this worked locally, local size 623MB vs original 2.24GB 💥

see updated NOTE about graphicx and friends (well, more just pointing out that these are core packages i think) in the install-tex-packages.sh, as well as These packages were identified by the tests.

Should footnotehyper and xurl be marked as official pandoc required packages in the MANUAL?

Sorry if I'm not making much sense, been a long night but I wanted to get this up so that the stack would build and hopefully be a green check mark xD

@svenevs svenevs changed the title WiP: reduce latex image size reduce latex image size Mar 6, 2019
@svenevs svenevs mentioned this pull request Mar 6, 2019
Closed
tarleb
tarleb approved these changes Mar 7, 2019
View reviewed changes
Copy link
Member

@tarleb tarleb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ 💯

@tarleb tarleb merged commit 5968e0b into master Mar 7, 2019
@tarleb
Copy link
Member

tarleb commented Mar 7, 2019

Should footnotehyper and xurl be marked as official pandoc required packages in the MANUAL?

Those aren't strictly required but only loaded when present. I had created a test file which does require those packages simply because loading them will produce nicer PDFs.

@tarleb
Copy link
Member

tarleb commented Mar 7, 2019

184 MB on Docker Hub. This rocks! 🚀

@svenevs
Copy link
Member Author

svenevs commented Mar 7, 2019

OMG!!!! I don't know about you but I'm pretty proud of us 🙂 I'll sort out the release=X.Y stuff soon! (the actual problem is that the CircleCI config needs to set PANDOC_VERSION to test the right tag being built, easy to fix but need to think about cleanest way)

@svenevs svenevs deleted the reduce-latex-size-redux branch March 7, 2019 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarleb tarleb tarleb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svenevs @tarleb