Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump toolranks from 9ca5587 to 2ac0b96 #791

Merged
merged 1 commit into from
Jun 19, 2020

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps toolranks from 9ca5587 to 2ac0b96.

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Bumps [toolranks](https://github.com/lisacvuk/minetest-toolranks) from `9ca5587` to `2ac0b96`.
- [Release notes](https://github.com/lisacvuk/minetest-toolranks/releases)
- [Commits](lisacvuk/minetest-toolranks@9ca5587...2ac0b96)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot added the dependencies Pull requests that update a dependency file label Jun 19, 2020
@BuckarooBanzay
Copy link
Contributor

@OgelGames nice 🎉

@BuckarooBanzay BuckarooBanzay merged commit 93f25d3 into master Jun 19, 2020
@dependabot-preview dependabot-preview bot deleted the dependabot/submodules/toolranks-2ac0b96 branch June 19, 2020 06:34
@OgelGames
Copy link
Contributor

OgelGames commented Jun 19, 2020

FYI, the new settings might need some tweaking to make the progression better, as the tools might become too good too quickly with the default values... Something like this would be better:

toolranks_levels = 100
toolranks_level_digs = 1000
toolranks_speed_multiplier = 2
toolranks_use_multiplier = 4

So that tools would reach max level at 100,000 digs, which I don't think would be too extreme considering many players already have tools above that (including myself).

BuckarooBanzay added a commit to pandorabox-io/pandorabox.io that referenced this pull request Jun 19, 2020
@BuckarooBanzay
Copy link
Contributor

So that tools would reach max level at 100,000 digs, which I don't think would be too extreme considering many players already have tools above that (including myself).

😲 maybe i should try that myself sometime... i lost too many high-ranked tools :(

I've added your config as-is in the minetest.conf
I did not look at the sourcecode though, how exactly is the speed-progression implemented? How does the speed look like at 100k digs?

@OgelGames
Copy link
Contributor

i lost too many high-ranked tools :(

Same here, I lost my highest level tool when I died and no bones were placed...

how exactly is the speed-progression implemented? How does the speed look like at 100k digs?

Everything is worked out linearly, and the settings define the max values (or multipliers), so in this case, level 1 would be 1.01x speed, 50 would be 1.5x speed, and level 100 (100k digs) would be 2x the original tool digging speed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants