Some crafted tools don't have a level and node counter when same tools crafter previously do

[int-ua]

Mentioned by Yad in #main, verified by me on mithril pickaxe. New one I just crafter didn't show node counter even after using it but I have two 6th level mithril pickaxes in storage.

[OgelGames]

So I found the issue; silver and mithril tools (from moreores) are not overridden with toolranks descriptions. Still can't find why it was working before though...

BTW, the description is part of the tool's metadata, that's why your other pick still shows its level 😉 (also I think if you used that old pick, the node count would not go up)

EDIT: This is when it stopped working: pandorabox-io/pandorabox-mods@f29d022#diff-8903239df476d7401cf9e76af0252622
The original toolranks supported moreores (https://github.com/lisacvuk/minetest-toolranks/blob/master/init.lua#L208), but TenPlus1's does not (https://notabug.org/TenPlus1/toolranks/src/master/init.lua#L115).

EDIT 2: Seems to be a dependency issue: lisacvuk/minetest-toolranks#5 (moreores dependency was removed in TenPlus1's toolranks)
The correct solution would be for moreores to override its own tools, just like other mods like lavastuff and multitools do.

[OgelGames]

I've opened two PR's to fix this issue: minetest-mods/moreores#37 and lisacvuk/minetest-toolranks#7

Also, of course, my fork can be used to fix it on the server in the meantime, as it is also compatible with TenPlus1's fork 😉

[thomasrudin]

Thanks @OgelGames, i switched to your forks and subscribed to the PR's 😄