Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions / Comments about storing constructs during IT/IGC #582

Closed
ggurdin opened this issue Aug 15, 2024 · 2 comments
Closed

Questions / Comments about storing constructs during IT/IGC #582

ggurdin opened this issue Aug 15, 2024 · 2 comments
Assignees

Comments

@ggurdin
Copy link
Collaborator

ggurdin commented Aug 15, 2024

  1. If I go through IT or IGC, then erase the message I was writing, should those construct uses also be erased?
  2. Tokens come from IGC span / IT continuances and tokenization on message send. These two categories are likely to have different offsets, so it's hard to say if the tokens are 'the same.' But it's likely that the tokens of selected choices will be stored twice. What's a good way to mitigate this? I tested with comparing offsets, but the offsets are changed when choices are added to the text.
@wcjord
Copy link

wcjord commented Aug 22, 2024

  1. The learner still did the thinking needed to make those choices so saving the records of it makes sense.
  2. After IT, I think we go ahead and assume that all tokens were awarded with construct uses during that flow.
    For IGC, the post-send system calculation of construct uses decides which type to award based on its overlap with an accepted match. You can use that to decide which tokens to exclude so they're not doubled up. So post-send, don't send any that the current system marks as 'ga.' These should have already been awarded in the interactions. Make sense?

@ggurdin
Copy link
Collaborator Author

ggurdin commented Aug 22, 2024

Yes, that makes sense!

@ggurdin ggurdin linked a pull request Aug 26, 2024 that will close this issue
@ggurdin ggurdin closed this as completed Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants