Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wip): monorepo structure #404

Closed
wants to merge 217 commits into from
Closed

feat(wip): monorepo structure #404

wants to merge 217 commits into from

Conversation

SarjuHansaliya
Copy link
Contributor

@SarjuHansaliya SarjuHansaliya commented May 17, 2023 •
edited
Loading

Summary

This PR moves entire component structure to monorepo

Checklist

  • core package
  • swap package
  • wallet-connectors package
  • wallet-modal package
  • SAR package
  • portfolio package
  • bridge-swap package
  • elixir package
  • pools package
  • governance package
  • airdrop package
  • shared package ( ongoing )
  • state-hooks package ( ongoing )
  • set up an example app that uses monorepo packages to make sure everything is working after migration
  • set up automated changelog generation using changeset
  • set up CI/CD actions to publish version. This should only go to the Honeycomb npm organisation. No need to duplicate it and publish to the historical Pangolin
  • set up size-limit on each PR to make sure all packages are tree-shakable
  • update readme, contribution guideline, github actions readme to include all essential information
  • make sure storybook runs properly in each package
  • add/update ReadMe file in each package
  • After everything is done, analyze all package json to make sure we have only necessary dependency
  • move all packages to @honeycomb-finance org. This should be dealt with above as part of the CI/CD process.
  • Integrate honeycomb packages to interface
  • (optional) move common dependency to monorepo root
  • (optional) move rollup configuration to common package
  • Resolve all SonarCloud issues

This PR is carry forwarded to Honeycomb-finance#5

@vercel
Copy link

vercel bot commented May 17, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 15, 2023 7:05am

HariSeldon23
HariSeldon23 reviewed May 17, 2023
View reviewed changes
monorepo/README.md Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jun 2, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 3 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 43 Code Smells

No Coverage information No Coverage information
29.6% 29.6% Duplication

@prodesert22 prodesert22 mentioned this pull request Aug 30, 2023
Merged
15 tasks
@HariSeldon23 HariSeldon23 mentioned this pull request Aug 30, 2023
Closed
@SarjuHansaliya
Merge pull request #527 from pangolindex/patch-packages
d51ce9b 
fix(monorepo): add patch package to monorepo example
@SarjuHansaliya
fix(monorepo): rename pangolindex to honeycomb-finance packages (#536)
a8eb8d2 
* v0.0.1

* v0.0.2

* v0.0.1

* v0.0.2

* v0.0.3

* v0.0.4

* fix: change with honeycomb

* fix: bridge honeycomb change

* fix: change honeycomb to honeycomb-finance

* fix: doc updated
@SarjuHansaliya
fix(monorepo): fix all storybook (#538)
db81ce2 
* fix: WIP storybook changes

* fix: change version

* fix: linting issue
@sonarcloud
Copy link

sonarcloud bot commented Sep 15, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug D 19 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 522 Code Smells

No Coverage information No Coverage information
72.1% 72.1% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@github-actions
Copy link

Last commit released to npm version: 7.3.9-internal.b7254b9

@SarjuHansaliya SarjuHansaliya mentioned this pull request Sep 16, 2023
Merged
26 tasks
@SarjuHansaliya
Copy link
Contributor Author

Closing this PR. This PR is superseded by Honeycomb-finance#5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HariSeldon23 HariSeldon23 HariSeldon23 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SarjuHansaliya @HariSeldon23 @prodesert22