fix: avoid requesting rango api when blockchain/symbol is invalid #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Kudos, SonarCloud Quality Gate passed!
|
|
Last commit released to npm version: |
SarjuHansaliya
approved these changes
Aug 16, 2023
SarjuHansaliya
added a commit
to Honeycomb-finance/components
that referenced
this pull request
Oct 17, 2023
* feat: monorepo structure spike * fix: add more core components * fix: add locale * fix: add some more components * fix: wip storybook implementation * fix: storybook preview file to tsx * fix: storybook import issue * fix: lint configuration * fix: news widget * fix: External Link * fix(core): remove rollup plugin from devDep * fix(core): prod rollup config * fix(core): move theme and locale to devDep * fix: news changes * fix: remove console * fix: update locale and theme changes * fix: WIP - Swap Widget * fix: wip hooks utils state swap * fix: update changes for current dev branch * fix: shared packages merge constants abi utils provider types * fix: moved abi constant theme utils locale to shared package * fix: update core package * fix: update shared package in state and hook packages * feat: added walletmodal package * fix: swap package update with shared package * fix: lint code * feat: update wallet modal and network selection * fix: add graphql to shared * feat: fix packages * feat: added images * feat: added react-app-env.d * fix: lint * feat: added sar package * fix: merge state and hooks packages * feat: added calculate reward rate to share package * fix: tryparseamount and maxamount * fix: packages names * fix: export use hedera token associated * fix: tsc * feat: change to state0hooks package * fix: swap type error resolve * fix: move tryParseAmount to shared package * feat: export usetotalsupply hook in state-hooks * feat: added portfolio package * fix: package.json * fix: package.json * fix: packages * fix: packages * fix: shared & state-hooks build type declaration issue * fix: wip wallet-connectors pkg * fix: build issue reslolved and path changes * fix: export tabs * feat: added bridge component * feat: export useToken * fix: lint and tsc * fix: package.json * fix: avoid requesting rango api when blockchain/symbol is invalid pangolindex#509 Co-authored-by: RanGojo <99180934+RanGojo@users.noreply.github.com> * feat: added active web3 react * fix: lint and useactiveweb3react * feat: export networkconnector * feat: export wallet connector arguments * feat: export errors * fix: package lock, tsc, lint and connectors * fix: move components under separed folder * fix: build * fix: build, tsc, lint, package.lock and move components to separed folder * fix: tsc and lint * fix: some dependancy changes * fix: small change * feat: added pool package * fix: wallet hooks * fix: walletmodal configuration with example setup * feat: export usetotalsupply hook in state-hooks * feat: fix minichef hooks * fix: mint and burn hooks * fix: pangochef hooks * feat: added sar in example app * feat: removed unsed files * fix: make honeycomn-provider pkg * fix: token balance * fix: remove console.log * fix: sdk version * feat: added portofolio in example app * fix: rollup * fix: restructure swap * fix: some tsc and lint issue resolve * fix: remove sdk * fix: update sdk * feat: added bridge in example * fix: lint tsc issue fix pkg version changes * fix: addliquidity components * fix: claim and remove components * fix: pangochef, minichef stake and wallet components * fix: components and tsc * fix: lint * fix: lint and packages * feat: implement rollup plugin to handle tsc-alias * fix: tsc * fix: build, tsc, lint, and added pool ui in example app * fix: wip elixir pkg * fix: crash in calculateuserrewardrate * fix: types in calculateuserrewardrate function * fix: rollup changes lint issue resolve * fix: add token-drawer package * fix: ti yse token drawer package * feat: added airdrop package * fix: change path for elixir pkg * feat: added airdrop to example app * feat: added governance package * fix: lint issue resolve * fix: resolve lint issue * feat: added governance in example app * fix: tsc, lint and packages * feat: rename governance package name * fix: review issues * feat: moved usetokencomparator to state-hooks * feat: move mint and burn to state folder * feat: fix tsc * fix: review issue * fix: default export and lint * fix: lint issue * fix: restructure state * fix: pool package in example * fix: lint resolve * feat: added readme in pool package * feat: added docs about walletmodal * fix: add patch package * feat: added readme for connectors * fix: wallet modal readme folder * fix: update wallet-connectors readme * feat: added readme for sar * fix: update getting start in sar readme * v0.0.1 * feat: added portfolio readme * feat: add readme for governance * fix: add dev and storybook in readme * feat: added readme for bridge * v0.0.2 * feat: added redme for airdrop * v0.0.1 * v0.0.2 * feat: added readme for core * feat: added readme for helper packages * feat: added readme for select token drawer * feat: added readme for shared * feat: added readme for swap widget * feat: added readme for state-hooks * feat: added readme for honeycomb-provider * v0.0.3 * v0.0.4 * feat: change swap default currency * feat: change order of apr in detais * feat: removed languages * feat: removed turkish * fix(monorepo): rename pangolindex to honeycomb-finance packages (pangolindex#536) * v0.0.1 * v0.0.2 * v0.0.1 * v0.0.2 * v0.0.3 * v0.0.4 * fix: change with honeycomb * fix: bridge honeycomb change * fix: change honeycomb to honeycomb-finance * fix: doc updated * fix(monorepo): fix all storybook (pangolindex#538) * fix: WIP storybook changes * fix: change version * fix: linting issue * fix(monorepo): move monorepo to root & remove src folder (#6) * fix(monorepo): lint issue resolve (#8) * fix(monorepo): tsc issue resolve (#9) * feat(monorepo): implement github actions (#7) * fix: add github action * fix: convert test script into javascript file * fix: change tsc action * fix: tsc issue * fix: add commitlint pkg * fix: example lint issue resolve * fix: try increasing swap size to 10gb * fix: lint issue in shared package * fix: update script name * fix(monorepo): add docs for new monorepo structure (#11) * fix: add docs for new monorepo structure * fix: update github action job name * feat(monorepo): add Changeset configuration & make ready for npm release (#10) * fix: Initial Changeset * fix: change changeset config repo * fix: change package public * fix: export other things build with release * fix: release script change * fix: export more from swap * fix: export necessary things * fix: some type changes * fix: change Pangoine to Honeycomb * fix: tsc issue * fix: export gelatostore * fix: lint issue * fix: add missing types for packages (#12) * fix: add type of packages * fix: add changeset * chore: update pull_request_template.md * fix(monorepo): fix circular dependency & pkg dependency versions (#13) * fix: circular dependency in core package * fix: ignore expected warning in rollup build * fix: circular dependency in swap package * fix: add missing @walletconnect/modal package which is being used by @walletconnect/ethereum-provider * fix: resolve circular depedancy on HashConnector * fix: resolve circular depedancy on state-hooks * fix: resolve elixir circular dependacy * fix: packages version * fix: resiolve lint issue * fix: add changeset * fix(monorepo): update orbs network package version (#14) * fix(monorepo): locale issue & png balance issue in breakdown modal (#15) * fix: text issue resolve * fix: resolve png balance * fix: add changeset and linting issue * fix: linting issue * fix(snapshot): try checkout branch directly * feat: governance support for flare, songbird & coston (#18) * feat: governance methods changed * fix: changed method * chore: remove sdk from governance package * chore: remove sdk from example app --------- Co-authored-by: Sarju Hansaliya <sarju.hansaliya@gmail.com> * chore: remove unused commitlint action * fix: added lifi api key & upgraded sdk version (#19) * feat: added lifi api key & upgraded sdk version * fix: lint issue * fix: sdk version updated (#20) * feat: sdk version updated * fix: update pangolindex/sdk --------- Co-authored-by: Sarju Hansaliya <sarju.hansaliya@gmail.com> --------- Co-authored-by: Pedro <pedroantonioppms@gmail.com> Co-authored-by: RanGojo <99180934+RanGojo@users.noreply.github.com> Co-authored-by: Justin Trollip <jtrollip@protonmail.com> Co-authored-by: Bilal Corbacioglu <bilalcorbacioglu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a minor improvement for integrating Rango API for the bridge section. In this PR, I've added a check to prevent calling Rango API when blockchain or token symbol is not supported by Rango.