Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functionality to delete a user's avatar #615

Merged
merged 3 commits into from
Feb 21, 2015
Merged

Functionality to delete a user's avatar #615

merged 3 commits into from
Feb 21, 2015

Conversation

Dominic28
Copy link
Contributor

Hey,
I needed this for a project. Feel free to merge this :) You just have to place a link somwhere in your design.

Personally, I renamed the uploadAvatar area to editAvatar and moved it in a user-controller which looks like this:

unbenannt

@Dominic28
Copy link
Contributor Author

I changed AvatarModel to self^^
I think panique wanted to put something into a new UserController. This is why i just placed it next to the uploadAvatar function.

@jjkirkpatrick
Copy link
Contributor

Ah, i must of missed that conversation, it really doesn't make a whole heap of sense where it currently is does it. as to this feature, I think that this should be implemented, as it extends on functionality that is already there, if you can add something you should be able to remove it. that's how i see it

@Dominic28
Copy link
Contributor Author

I don't have a link to the issue right now, but it was at the time where @panique splitted the login model.
The UserModel is already existing and he wanted to move the user stuff from the login controller to a user controller.

@jjkirkpatrick
Copy link
Contributor

Side note, You should probably add a way for the user to use this feature, i cant imagine it will get merged without it

@panique
Copy link
Owner

panique commented Feb 21, 2015

Thanks, excellent! I'll make a test tomorrow and then merge it!
Personal notice: Maybe this should also check for .png etc. too

@panique
Copy link
Owner

panique commented Feb 21, 2015

@Dominic28 Can you please add something that makes this feature useable for the user ? currently it's more or less unreachable code :)

@Dominic28
Copy link
Contributor Author

I added the link to the upload avatar page and renamed it to edit avatar. I hope this is okay for you.

panique added a commit that referenced this pull request Feb 21, 2015
Functionality to delete a user's avatar
@panique panique merged commit 45c09c3 into panique:develop Feb 21, 2015
@panique
Copy link
Owner

panique commented Feb 21, 2015

BIG Thanks, works perfectly! :)

@Dominic28 Dominic28 deleted the editAvatar branch February 21, 2015 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants