Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check stdConn buffer is nil when ResetBuffer #122

Closed
wants to merge 1 commit into from

Conversation

hihaha
Copy link
Contributor

@hihaha hihaha commented Jul 31, 2020


name: Pull request
about: fix stdConn ResetBuffer function on windows
title: ''
labels: ''
assignees: ''

1. Are you opening this pull request for bug-fixs, optimizations or new feature?

2. Please describe how these code changes achieve your intention.

3. Please link to the relevant issues (if any).

4. Which documentation changes (if any) need to be made/updated because of this PR?

4. Checklist

  • I have squashed all insignificant commits.
  • I have commented my code for explaining package types, values, functions, and non-obvious lines.
  • I have written unit tests and verified that all tests passes (if needed).
  • I have documented feature info on the README (only when this PR is adding a new feature).
  • (optional) I am willing to help maintain this change if there are issues with it later.

@codecov
Copy link

codecov bot commented Jul 31, 2020

Codecov Report

Merging #122 into master will decrease coverage by 0.40%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #122      +/-   ##
==========================================
- Coverage   86.00%   85.59%   -0.41%     
==========================================
  Files          18       18              
  Lines        1400     1402       +2     
==========================================
- Hits         1204     1200       -4     
- Misses        161      166       +5     
- Partials       35       36       +1     
Impacted Files Coverage Δ
connection_windows.go 77.39% <100.00%> (+0.40%) ⬆️
eventloop_unix.go 70.55% <0.00%> (-3.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42e04dd...28e5017. Read the comment docs.

@panjf2000
Copy link
Owner

I don't think that buffer would be empty before the reset in ResetBuffer(), did you experience this kind of issue?

@panjf2000 panjf2000 closed this in 0a56201 Aug 1, 2020
panjf2000 added a commit that referenced this pull request Aug 1, 2020
@hihaha
Copy link
Contributor Author

hihaha commented Aug 2, 2020

I don't think that buffer would be empty before the reset in ResetBuffer(), did you experience this kind of issue?

是的,遇到过这个问题,当前PR修改不完善,后面会重新提交一个PR

0-haha pushed a commit to 0-haha/gnet that referenced this pull request Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants