feat: add multiple listener support #413
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panjf2000
reviewed
Oct 18, 2022
| if ln, err = initListener(network, addr, options); err != nil { | ||
| return | ||
| listeners := make(map[int]*listener) | ||
| for _, addr := range strings.Split(addrs, ",") { |
There was a problem hiding this comment.
I think we should update parseProtoAddr() to support string format: "tcp://192.168.0.100:8000,tcp://192.168.0.100:8001,tcp://192.168.0.100:8002" to maintain compatibility when gnet supports multiple listener with different protocols in the future.
There was a problem hiding this comment.
Makes sense, thanks. I will try to fix it and add appropriate tests.
panjf2000
requested changes
Oct 18, 2022
panjf2000
force-pushed
the
dev
branch
7 times, most recently
from
bac08a4
to
1418ec9
Compare
panjf2000
force-pushed
the
dev
branch
3 times, most recently
from
099ac41
to
9b502e3
Compare
|
Wondering if this supports binding multiple protocols at one, for ex. Mixing udp and tcp. Also, is there any news on this? |
|
Is there a planned time to accept this PR? |
This PR is still in WIP status, I'd love to review it once @leki75 finishes it. |
panjf2000
force-pushed
the
dev
branch
3 times, most recently
from
fa1dc24
to
5d1cf9e
Compare
|
Move to #578 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Are you opening this pull request for bug-fixes, optimizations or new feature?
New feature
2. Please describe how these code changes achieve your intention.
This PR will add multi-listener support. The user can specify multiple IP:port pairs separated by commas.
3. Please link to the relevant issues (if any).
4. Which documentation changes (if any) need to be made/updated because of this PR?
The
gnet.Runcommand will accept multiple IP:port pairs like this:4. Checklist