Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adopted for python 3.5 #5

Closed
wants to merge 1 commit into from
Closed

Conversation

ssheremeta
Copy link

No description provided.

@sourcery-ai
Copy link

sourcery-ai bot commented Jan 26, 2021

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.88%.

Quality metrics Before After Change
Complexity 3.19 ⭐ 3.19 ⭐ 0.00
Method Length 92.15 🙂 90.73 🙂 -1.42 👍
Working memory 15.91 ⛔ 15.55 ⛔ -0.36 👍
Quality 59.18% 🙂 60.06% 🙂 0.88% 👍
Other metrics Before After Change
Lines 1276 1303 27
Changed files Quality Before Quality After Quality Change
setup.py 72.25% 🙂 76.21% ⭐ 3.96% 👍
airflow_home/dags/01_session_example.py 51.20% 🙂 51.20% 🙂 0.00%
airflow_home/dags/02_session_example_load_from_file.py 73.96% 🙂 73.87% 🙂 -0.09% 👎
airflow_home/dags/03_batch_example.py 56.17% 🙂 56.17% 🙂 0.00%
airflow_home/dags/04_batch_example_failing.py 53.97% 🙂 53.97% 🙂 0.00%
airflow_home/dags/05_batch_example_verify_in_spark.py 55.01% 🙂 55.01% 🙂 0.00%
airflow_home/dags/06_batch_example_verify_in_yarn.py 55.01% 🙂 55.01% 🙂 0.00%
airflow_home/plugins/airflow_livy/batch.py 61.43% 🙂 62.31% 🙂 0.88% 👍
airflow_home/plugins/airflow_livy/session.py 60.25% 🙂 61.52% 🙂 1.27% 👍
batches/join_2_files.py 39.52% 😞 39.50% 😞 -0.02% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
airflow_home/plugins/airflow_livy/batch.py LivyBatchOperator.__init__ 3 ⭐ 179 😞 34 ⛔ 41.19% 😞 Try splitting into smaller methods. Extract out complex expressions
airflow_home/plugins/airflow_livy/session.py LivySessionOperator.__init__ 3 ⭐ 172 😞 32 ⛔ 41.99% 😞 Try splitting into smaller methods. Extract out complex expressions
airflow_home/plugins/airflow_livy/batch.py LivyBatchOperator.submit_batch 2 ⭐ 147 😞 35 ⛔ 45.24% 😞 Try splitting into smaller methods. Extract out complex expressions
airflow_home/plugins/airflow_livy/session.py LivySessionOperator.create_session 2 ⭐ 144 😞 33 ⛔ 45.71% 😞 Try splitting into smaller methods. Extract out complex expressions
airflow_home/plugins/airflow_livy/session.py LivySessionOperator.execute 7 ⭐ 160 😞 11 😞 53.10% 🙂 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@ssheremeta ssheremeta closed this Jan 26, 2021
@ssheremeta ssheremeta deleted the python35 branch January 26, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant