Adding CIRCLE_REPOSITORY_URL as origin for full repo for 51 bug fix #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevector
changed the title
|
I have time to test today. I'll report later in the day on the results. Thank you! |
|
@stevector this works for me as tested previously. Can we please merge? The dev build I have been using has expired. Thanks. |
|
Yes, I'll cut the tag later today! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to address #51. As best I can tell, the way I wrote the Orb to use two repos within it's build process (a clone from Pantheon in addition to the clone from GitHub/BitBucket that comes by default in CI) had the side effect of leaving the
urlkey empty in thebuild-metadata.jsonfile.I think I didn't notice this problem earlier because the real repos that I use the Orb with are repos that pre-date the Orb and the clean-up process called out in the #51 bug report only needs to find one environment with the
urlvalue set.Anyway, this change seems good to merge but I'd like validation from at least one tester in #51. See this PR for an example of how to test this particular Orb revision: https://github.com/stevector/nerdologues-d8/pull/373/files