Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terminus whoami no longer exits with return code 1 when unauthenticated #1697

Open
danielbachhuber opened this issue May 3, 2017 · 4 comments

Comments

@danielbachhuber
Copy link
Contributor

danielbachhuber commented May 3, 2017

In terminus 0.x, terminus whoami would exit with return code 1 when unauthenticated.

In terminus 1.x, terminus whoami exits with return code 0 when unauthenticated.

As a terminus user, it's easier to use terminus whoami in scripts when its return codes reflect authentication state.

Related lcache/wp-lcache#119

@TeslaDethray
Copy link
Contributor

Added to our Jira queue as AL-1038

@kzalewski
Copy link

How much longer do we have to wait for this simple fix? The auth:whoami command needs to exit with a 0 if the user is authenticated, and 1 if the user is not authenticated. This used to work in Terminus 0.13.x, and now it's broken in Terminus 1.x.

greg-1-anderson added a commit that referenced this issue Jan 11, 2019
@greg-1-anderson
Copy link
Member

There are a lot of Terminus issues; this one probably just got forgotten. I created a PR to kick things off again.

@kzalewski
Copy link

Awesome! Thanks Greg. PR #1926 looks good to me. I tested it by patching locally, and it works as expected. I appreciate the quick response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants