Make the —yes/y arg set all confirmations to yes
#1201
Conversation
|
@ronan, thanks for your PR! By analyzing the blame information on this pull request, we identified @TeslaDethray and @greg-1-anderson to be potential reviewers |
|
Sure, works for me; however, I think that we should also make --yes imply --no-interaction. Anything that is not |
|
@TeslaDethray Was saying the opposite. I'm agnostic. Let's merge this as is and re-address with product/design when we get to command for which this matters |
|
Agree we should leave that out until certain about how we want it. |
|
I'm in favor of merging here. |
|
|
||
| /** | ||
| * @param $question | ||
| * @return string |
There was a problem hiding this comment.
Return is not always a string.
| @@ -37,4 +38,16 @@ protected function log() | |||
| { | |||
| return $this->logger; | |||
| } | |||
|
|
|||
| /** | |||
| * @param $question | |||
| @@ -37,4 +38,16 @@ protected function log() | |||
| { | |||
| return $this->logger; | |||
| } | |||
|
|
|||
| /** | |||
|
Changes Unknown when pulling 496c398 on addition/confirm-yes into * on master*. |
|
I strongly dislike the idea of handling interactivity from inside these commands. If we wish to retain --yes, -y, it would be better to implement them on an as-needed basis. |
|
I am misunderstanding one of your two sentences.
Meaning you prefer to have a
Meaning you'd prefer to put a I must be mis-parsing one of those. |
Revert "Merge pull request #1201 from pantheon-systems/addition/confi…
@greg-1-anderson, @TeslaDethray This works bit is kinda simplistic. It differs from
--no-interactionin that it only affects confirmations and defaults to 'y' and not 'n'.