Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LOPS-2119 - Wait for a healthcheck before releasing the command #2564

Merged
merged 11 commits into from
Apr 9, 2024
Merged

LOPS-2119 - Wait for a healthcheck before releasing the command #2564

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
0cd53e0
wait for a healthcheck before releasing the command
stovak Apr 3, 2024
308aa17
log messages
stovak Apr 3, 2024
8276189
wait for the response to come back before ending the script
stovak Apr 4, 2024
ae061a6
adding timeout
stovak Apr 4, 2024
dc69d4e
adding failure message
stovak Apr 4, 2024
0603105
bikesheding
stovak Apr 4, 2024
a38c2c8
updated error message
stovak Apr 4, 2024
983ab68
throw exception instead of exit.
stovak Apr 4, 2024
c686975
flipping the condition
stovak Apr 4, 2024
0e99cad
wait for wake trait
stovak Apr 4, 2024
519777e
make number of wake retries configurable
stovak Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/Commands/Site/CreateCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,16 @@ public function create($site_name, $label, $upstream_id, $options = ['org' => nu
if ($site = $this->getSiteById($workflow->get('waiting_for_task')->site_id)) {
$this->log()->notice('Deploying CMS...');
$this->processWorkflow($site->deployProduct($upstream->id));
$this->log()->notice('Deployed CMS');
$this->log()->notice('Waiting for site availability...');
$waits = 0;
do {
sleep(5);
$woke = $site->getEnvironments()->get('dev')->wake();
// if success is empty, then the site is still waking up.
$waits++;
stovak marked this conversation as resolved.
Show resolved Hide resolved
// If we've waited more than 25 seconds, then something is wrong.
} while (($woke['success'] ?? false) !== true || $waits < 5);
$this->log()->notice('Your site has been created successfully!');
stovak marked this conversation as resolved.
Show resolved Hide resolved
}
}
}
6 changes: 3 additions & 3 deletions src/Models/Environment.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@
use Pantheon\Terminus\Collections\Domains;
use Pantheon\Terminus\Collections\EnvironmentMetrics;
use Pantheon\Terminus\Collections\Workflows;
use Pantheon\Terminus\Helpers\LocalMachineHelper;
use Pantheon\Terminus\Exceptions\TerminusException;
use Pantheon\Terminus\Friends\SiteInterface;
use Pantheon\Terminus\Friends\SiteTrait;
use Pantheon\Terminus\Exceptions\TerminusException;
use Pantheon\Terminus\Helpers\LocalMachineHelper;

/**
* Class Environment
Expand Down Expand Up @@ -1000,7 +1000,7 @@ public function sftpConnectionInfo()
*
* @return array
*/
public function wake()
public function wake(): array
{
$domains = array_filter(
$this->getDomains()->all(),
Expand Down
Loading