Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keyclick duration should be scaled by sample-rate #2

Closed
x42 opened this issue Jul 12, 2012 · 1 comment
Closed

keyclick duration should be scaled by sample-rate #2

x42 opened this issue Jul 12, 2012 · 1 comment
Labels
bug
Milestone
zero-six (v0.6.0)

Comments

@x42
Copy link
Collaborator

x42 commented Jul 12, 2012

in src/tonegen.c the envAtkClkMinLength and envAtkClkMaxLength parameters should be scaled according to sample-rate during initialization.

currently they're hardcoded for 44.1kHz
@x42
Copy link
Collaborator Author

x42 commented Jul 12, 2012

fixed in d31c9e4

@x42 x42 closed this as completed Jul 12, 2012
@domichel domichel mentioned this issue Jul 16, 2012
Closed
x42 added a commit that referenced this issue Nov 2, 2019
@x42
Increase default Atom buffer-size for b3
4f5e224 
This fixes an issue on some systems where the DSP can emit more
messages than the UI can consume in a given time.

Also modern forge.h (1.16.0) does not correctly protect against overflow.
----
#0  0x00005555555838f2 in lv2_atom_forge_raw (forge=0x555555b72a10, data=0x7fffe415a9c0, size=8) at /usr/lib/lv2/atom.lv2/forge.h:292
#1  0x000055555558399f in lv2_atom_forge_write (forge=0x555555b72a10, data=0x7fffe415a9c0, size=8) at /usr/lib/lv2/atom.lv2/forge.h:310
#2  0x0000555555583d65 in lv2_atom_forge_property_head (forge=0x555555b72a10, key=16, context=0) at /usr/lib/lv2/atom.lv2/forge.h:636
#3  0x000055555558434a in forge_kvcontrolmessage (forge=0x555555b72a10, uris=0x555555b72ad0, key=0x5555555a8964 "vibrato.lower", value=0) at ../b_synth/uris.h:169
#4  0x0000555555584c23 in mctl_cb (fnid=34, fn=0x5555555a8964 "vibrato.lower", val=0 '\000', mm=0x0, arg=0x555555b72a10) at ../b_synth/lv2.c:304
#5  0x0000555555562b49 in controlFunctionHook (mcfg=0x555555b7b710, ctrlF=0x555555b7ef00, val=0 '\000') at ../src/midi.c:504
#6  0x0000555555562cda in notifyControlChangeById (mcfg=0x555555b7b710, id=34, val=0 '\000') at ../src/midi.c:542
..
---
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
zero-six (v0.6.0)
Development

No branches or pull requests
1 participant
@x42