This repository has been archived by the owner on Jun 23, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Shading rule
rename
doesn't support such patterns as"com.typesafe.akka.akka-http-core.*"
or"com.typesafe.akka.akka-http-core.**"
.Also during substitution of String literals in such case
some of them substitutes inconsistently and code starts to look like:
Solution
Add dash as a valid symbol for identifiers.
Disclaimer
I am not pretty sure in that solution (because have no experience in such low-level details) and that pull request is just conscripted to start a discussion.
Please be patient and provide your comments.
Thank you for your time.