Remove stale "pants.pex for integration tests" mechanism #10279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…un from the PYTHONPATH of the test target, which will automatically include either loose sources or requirements, depending on whether the test is run in or out of the pantsbuild/pants repo. # Rust tests will be skipped. Delete if not intended. [ci skip-rust-tests]
jsirois
approved these changes
Jul 7, 2020
CI will still use the |
OK. It looks like that's true. It's also unfortunately obscure and a good seed for confusion, but just directly uploading and downloading the .so definitely is out of scope. |
Eric-Arellano
approved these changes
Jul 7, 2020
Comment on lines
-126
to
-130
| no_regen_pex="${NO_REGEN_PEX:-${TRAVIS}}" | ||
| if [[ "${test_goal_used}" == 'true' && "${no_regen_pex}" != 'true' ]]; then | ||
| "$HERE/build-support/bin/bootstrap_pants_pex.sh" | ||
| echo -e "Finished bootstrapping pants.pex for integration tests.\n" >&2 | ||
| fi |
…k in future versions (via pantsbuild#7654) that implementation will not require nesting to validate: only concurrent runs.
stuhood
force-pushed
the
stuhood/remove-pants.pex-for-integration-tests
branch
from
3703fed
to
b8169c1
Compare
Eric-Arellano
approved these changes
Jul 7, 2020
stuhood
added a commit
that referenced
this pull request
Jul 31, 2020
### Problem Integration tests depend transitively on the `native_engine.so`, which is continuously validated because it must be present to run, and which is bootstrapped before pants starts up. But integration tests were also including the rust sources unnecessarily. ### Solution Remove the dependency on the rust sources, and the associated target. Also, align the comment about our use of `pants_local_binary` to what we learned in #10279. [ci skip-rust] [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Since #8265, we have been running
PantsRunIntegrationTests from loose sources in the repository, which are included viasrc/python/pants/testutil:int-test's dependency onsrc/python/pants/bin:pants_local_binary. That change thus removed the need for thepants.pexfrom our wrapper scripts.Solution
Remove the "
pants.pexfor integration tests" mechanism. Post #8625, pants is run from the PYTHONPATH of the test target, which will automatically include either loose sources or apants_requirementtarget, depending on whether the test is run in or out of the pantsbuild/pants repo.Additionally, remove one set of tests that was attempting to test that nested runs of pants do not deadlock. #7654 will eventually allow that issue to be resolved by allowing the concurrent run rather than via any sort of automatic disabling of
pantsd, and that is much easier to test via concurrent runs without nesting.[ci skip-rust-tests]