Remove rust source include from integration tests #10522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…luded via the bootstrapped `native_engine.so`. [ci skip-build-wheels]
Eric-Arellano
approved these changes
Jul 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Integration tests depend transitively on the
native_engine.so, which is continuously validated because it must be present to run, and which is bootstrapped before pants starts up. But integration tests were also including the rust sources unnecessarily.Solution
Remove the dependency on the rust sources, and the associated target. Also, align the comment about our use of
pants_local_binaryto what we learned in #10279.[ci skip-rust]
[ci skip-build-wheels]