Upgrade zinc to 1.0.0-X7 (python portion)
#4419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuhood
approved these changes
Apr 4, 2017
| val = base64.b64decode(val) | ||
| for rebased_from, rebased_to in rebase_mappings: | ||
| val = val.replace(rebased_from, rebased_to) | ||
| rebased_line = '{}{}\n'.format(prefix, base64.b64encode(val)) |
There was a problem hiding this comment.
Should be possible to skip re-encoding if no changes were made? Could set a variable inside the loop to mark a change.
There was a problem hiding this comment.
rebase_pants_home_anywhere_base64 flag means lines in this section contains b64 encoded paths, so detecting if replace happens is unnecessary imo. Same is true for other flags like rebase_pants_home_anywhere or rebase_pants_home_prefix, i.e, once set no further optimization is needed.
baroquebobcat
added a commit
to twitter/pants
that referenced
this pull request
Apr 12, 2017
This reverts commit 8b6adf2.
stuhood
added a commit
to twitter/pants
that referenced
this pull request
Apr 24, 2017
This reverts commit 8b6adf2.
lenucksi
pushed a commit
to lenucksi/pants
that referenced
this pull request
Apr 25, 2017
### Problem Notable change in `1.0.0-X7`: sbt/zinc@a25d135 to fix zinc swallow javac error messages. Two zinc `TODO`s that we should push upstream before next upgrade are: * sbt/util#75 to generate machine independent analysis file. So we don't have to do the extra work in this PR decode/encode `classpath hash`. * sbt/zinc#218 jdk 7 compatibility. If zinc decide to discontinue jdk7 support we should start to communicate with pants users. Since the incompatibility is already introduced, this PR has to exclude the jdk8 compiled deps. ### Solution Upgrade and workarounds of these two TODOs, see comments inline. ### Result Passed travis
lenucksi
pushed a commit
to lenucksi/pants
that referenced
this pull request
Apr 25, 2017
### Problem The zinc 1.0.0-X7 upgrade resulted in a few issues, including complete target invalidation (pantsbuild#4477), and some unconfirmed assertion failures from within zinc. ### Solution This reverts pantsbuild#4419 until after the `1.3.0` stable branch has been cut. It should be re-landed immediately afterward.
thesamet
pushed a commit
to thesamet/pants
that referenced
this pull request
May 9, 2017
### Problem The zinc 1.0.0-X7 upgrade resulted in a few issues, including complete target invalidation (pantsbuild#4477), and some unconfirmed assertion failures from within zinc. ### Solution This reverts pantsbuild#4419 until after the `1.3.0` stable branch has been cut. It should be re-landed immediately afterward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Notable change in
1.0.0-X7: sbt/zinc@a25d135 to fix zinc swallow javac error messages.Two zinc
TODOs that we should push upstream before next upgrade are:classpath hash.Solution
Upgrade and workarounds of these two TODOs, see comments inline.
Result
Passed travis