Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split file set by line instead of spaces to resolve errors #6247

Merged
merged 2 commits into from Jul 28, 2018
Merged

Split file set by line instead of spaces to resolve errors #6247

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
feb561c
split fileset by line instead of spaces
dotordogh Jul 27, 2018
081df47
remove extra line
dotordogh Jul 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/python/pants/scm/git.py
View file
Open in desktop
Expand Up @@ -165,7 +165,7 @@ def changed_files(self, from_commit=None, include_untracked=False, relative_to=N
uncommitted_changes = self._check_output(['diff', '--name-only', 'HEAD'] + rel_suffix,
raise_type=Scm.LocalException)

files = set(uncommitted_changes.split())
files = set(uncommitted_changes.splitlines())
if from_commit:
# Grab the diff from the merge-base to HEAD using ... syntax. This ensures we have just
# the changes that have occurred on the current branch.
Expand Down