Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix ordering of args from compiler_option_sets and add test for scalac profiling #7683
The options from
This breaks the ability to use options which require two successive arguments via compiler option sets. Scalac profiling is an example of this, requiring a successive output file argument.
Scalac profiling is now possible using a compiler option set!
CMLivingston left a comment
The set usage was mainly to de-dupe args in the event that they are specified twice and this adversely affects the compilation process somehow. Admittedly, I don't know whether this impacts zinc or clang/gcc. If this came up we could probably cast as an OrderedSet and return a list from that. LGTM.
Sorry, yes, list is absolutely the correct behavior. As noted in a slack channel with @stuhood and @ShaneDelmore just now, we almost definitely want to make sure that option sets get applied at the end of the argv in order to give them the highest precedence -- that should be fixed and tested in this PR too.
May 10, 2019
It turns out this was already the case, so I'm comfortable enough about not adding further testing.