Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always capture and cache Digests in coursier and ivy #7835

Merged

Conversation

Projects
None yet
2 participants
@stuhood
Copy link
Member

commented Jun 2, 2019

Problem

Capturing digests for coursier and ivy artifacts is currently optional, presumably due to the performance impact of not being cached run over run.

Solution

#7241 added support for stashing Digests next to digested files, and support for providing a Digest hint that will skip snapshotting if the Digest is already stored. We use that support here to always-snapshot 3rdparty inputs (and to skip re-snapshotting if a Digest was stashed).

Result

One fewer option, and slightly better performance when re-running.

@cosmicexplorer
Copy link
Contributor

left a comment

Extremely cool!

@stuhood

This comment has been minimized.

Copy link
Member Author

commented Jun 2, 2019

Lots of network flakiness (and one actual flake: #7836), but previous runs of those shards were good, and would be unaffected by the most recent change. Merging.

@stuhood stuhood merged commit 944b42c into pantsbuild:master Jun 2, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@stuhood stuhood deleted the twitter:stuhood/capture-3rdparty-digests-by-default branch Jun 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.