Always capture and cache Digests in coursier and ivy #7835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lots of network flakiness (and one actual flake: #7836), but previous runs of those shards were good, and would be unaffected by the most recent change. Merging. |
illicitonion
added a commit
that referenced
this pull request
Jul 9, 2019
This reverts commit 944b42c.
stuhood
added a commit
that referenced
this pull request
Jul 28, 2019
### Problem When hermetic execution is used for `zinc` or `rsc` and `DirectoryDigests` are not available for input classpath entries, we currently trigger a warning. But this being only a warning (and not an error) definitely masks a few different potential bugs, and might allow more to slip in in the future. ### Solution Convert the warning into an error, and fix all of the issues exposed by that change: * In some `Task` configurations, `ResourcesTask` could run before the compilers, meaning that its resources needed to be digested. This also prepares for remote execution of tests. * When `--no-use-classpath-jars` was in use: * `ClasspathEntry`s having digests was preventing them from having an equality match in order to be removed from the classpath. * `rsc` was universally adding the jar for a target to the classpath, even though it was empty. * Both the loose classpath and output jar needed to be captured in hermetic execution. * Tools that were bootstrapped were not propagating the digests that had already been captured for them in #7835, which caused "global" scalac plugins to not have digests. ### Result Hermetic execution has improved validation that should help to catch additional bugs in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Capturing digests for
coursierandivyartifacts is currently optional, presumably due to the performance impact of not being cached run over run.Solution
#7241 added support for stashing
Digests next to digested files, and support for providing aDigesthint that will skip snapshotting if theDigestis already stored. We use that support here to always-snapshot 3rdparty inputs (and to skip re-snapshotting if aDigestwas stashed).Result
One fewer option, and slightly better performance when re-running.