Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-instate PosixFS Threadpool #7848

Merged

Conversation

Projects
None yet
3 participants
@illicitonion
Copy link
Contributor

commented Jun 4, 2019

Removing this threadpool introduced a significant performance regression to the export goal, for as-yet undiagnosed reasons.

This is a dirty revert of #7822, #7688, and #7685, and adding a tiny commit on top to support thread-local logging.

I will hopefully investigate and re-land fixing up the regression at some point.

@illicitonion illicitonion requested review from stuhood and ity Jun 4, 2019

@stuhood

stuhood approved these changes Jun 5, 2019

@stuhood stuhood added this to the 1.17.x milestone Jun 5, 2019

@illicitonion illicitonion merged commit 0d9d214 into pantsbuild:master Jun 5, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@illicitonion illicitonion deleted the twitter:dwagnerhall/revertthreadpool branch Jun 5, 2019

illicitonion added a commit that referenced this pull request Jun 5, 2019

Re-instate PosixFS Threadpool (#7848)
Removing this threadpool introduced a significant performance regression to the `export` goal, for as-yet undiagnosed reasons.

This is a dirty revert of #7822, #7688, and #7685, and adding a tiny commit on top to support thread-local logging.

I will hopefully investigate and re-land fixing up the regression at some point.
@ity

ity approved these changes Jun 5, 2019

Copy link
Contributor

left a comment

had a quick browse - lgtm, thanks!

illicitonion added a commit to twitter/pants that referenced this pull request Jun 19, 2019

illicitonion added a commit that referenced this pull request Jun 19, 2019

Switch back to using one threadpool (#7898)
This reverts #7848 and fixes the performance issue found in it.

The first commit is just a revert (with a few manual merge cleanups), the second commit fixes the performance issue.

Fixes #7896
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.