Replace futures-timer with tokio_timer #7822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illicitonion
added a commit
that referenced
this pull request
Jun 4, 2019
This reverts commit a99faa3.
illicitonion
added a commit
to twitter/pants
that referenced
this pull request
Jun 4, 2019
This reverts commit a99faa3.
illicitonion
added a commit
that referenced
this pull request
Jun 5, 2019
Removing this threadpool introduced a significant performance regression to the `export` goal, for as-yet undiagnosed reasons. This is a dirty revert of #7822, #7688, and #7685, and adding a tiny commit on top to support thread-local logging. I will hopefully investigate and re-land fixing up the regression at some point.
illicitonion
added a commit
that referenced
this pull request
Jun 5, 2019
Removing this threadpool introduced a significant performance regression to the `export` goal, for as-yet undiagnosed reasons. This is a dirty revert of #7822, #7688, and #7685, and adding a tiny commit on top to support thread-local logging. I will hopefully investigate and re-land fixing up the regression at some point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now run all our futures on tokio runtimes, so we can do this.
This removes a dep, and in particular, a dep which we had to fork from upstream.
It also means we have one fewer background thread running.