Fix doc syncing for .x removal
#56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huonw
commented
Jan 3, 2024
| if [ ! -d "pantsbuild.org/$DESTINATION_DIR" ]; then | ||
| DESTINATION_DIR="docs" | ||
| fi | ||
| echo "DESTINATION_DIR=$(echo "$DESTINATION_DIR")" >> "${GITHUB_OUTPUT}" | ||
| echo "DESTINATION_DIR=$(echo "$DESTINATION_DIR")" | tee -a "${GITHUB_OUTPUT}" |
There was a problem hiding this comment.
Drive-by change, for non-confidential values like this, printing the value to stdout helps with debugging, and tee -a is a handy way to do so without needing to repeat the echos.
There was a problem hiding this comment.
I'm gonna try really hard to keep this one in my pocket.
huonw
commented
Jan 3, 2024
Comment on lines
+63
to
+64
| mkdir -p "pantsbuild.org/${{ steps.get-destination-dir.outputs.DESTINATION_DIR }}/reference" | ||
| cp help-all.json "pantsbuild.org/${{ steps.get-destination-dir.outputs.DESTINATION_DIR }}/reference" |
There was a problem hiding this comment.
(This appears to be an existing issue with this action. fixed here but not directly related to #48.)
This was referenced Jan 3, 2024
thejcannon
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the doc syncer now that we don't have
.xin the directories (#48), per #48 (comment)It also makes an unrelated fix, so that my test works.
Test: #57, https://github.com/pantsbuild/pantsbuild.org/actions/runs/7403672327/job/20143898054