Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs site for version 2.18.1 #71

Closed
wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Jan 8, 2024

@github-actions github-actions bot requested a review from huonw January 8, 2024 00:21
@huonw
Copy link
Contributor

huonw commented Jan 8, 2024

@thejcannon this is a doc sync PR that I would've expected to have no changes to the generated reference files, now that we've theoretically resolved #37, with:

Are you able to take a look and work out what's changed and if it requires updates on our side? For instance, the help-all.json seems to have significant changes, plus a bunch of extra files, and many files with minor changes too.

Copy link
Member

@thejcannon thejcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I thumbed through a bit, and commented on a few things.

plus a bunch of extra files

Those seem to be from backends that weren't added to the static list of backends to activate on the relevant branch.

Part of this change was eliminating the need for a static list of backends to generate docs for, and instead just generating reference docs for all possible backends.

We can apply all of these fixes/changes using the existing help-all's version to ensure we're minimizing changes and then do another round of this PR (trying to sync with a later version)

thejcannon added a commit that referenced this pull request Jan 9, 2024
See
#71 (comment)

---------

Co-authored-by: Huon Wilson <wilson.huon@gmail.com>
@huonw
Copy link
Contributor

huonw commented Jan 9, 2024

Closing and trying again after the next batch of fixes #73, #80, #81 (nice work @thejcannon )

@huonw huonw closed this Jan 9, 2024
@huonw huonw deleted the automation/sync-2.18.1 branch January 9, 2024 21:46
@huonw
Copy link
Contributor

huonw commented Jan 9, 2024

#82

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants