Obey PANTS_BOOTSTRAP_URLS properly, update to science 0.2.2
#293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huonw
commented
Sep 26, 2023
| @@ -40,7 +40,7 @@ members = [ | |||
| # N.B.: We name the scie-pants binary scie-pants.bin since the scie itself is named scie-pants | |||
| # which would conflict when packaging. | |||
| name = "scie-pants.bin" | |||
| executable = true | |||
There was a problem hiding this comment.
The error for this one referred to files[1].executable which appears to be 1-indexed (AFAICT, this is the first entry in the files list); is that expected?
There was a problem hiding this comment.
It's expected, but perhaps a bad choice. It carried over from my Pex lockfile parsing diagnostics. There I saw a large audience was comprised of ML folks and I've been continually surprised by how much ML they know combined with how little programming language familiarity they have. I should probably just add a parenthetical to diagnostic messages that array indexes are X-based.
This comment was marked as resolved.
This comment was marked as resolved.
jsirois
approved these changes
Sep 27, 2023
jsirois
reviewed
Sep 27, 2023
huonw
changed the title
PANTS_BOOTSTRAP_URLS properly, update to science 0.2.2
Merged
huonw
added a commit
that referenced
this pull request
Sep 29, 2023
The only user-visible feature is #293, plus the doc changes in #296. There's various (hopefully, internal-only) dependency upgrades and similar. Full changes: v0.10.2...91477f6 ([This time](#289), I remembered to bump `Cargo.lock`.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates to https://github.com/a-scie/lift/releases/tag/v0.2.2, which has diagnostics to detect invalid/ignored entries in the configuration files. This detects two:
scie-pants.binfile wasn't being marked as executable properly... which suggests it doesn't need to bePANTS_BOOTSTRAP_URLSenv var wasn't being passed through toptexproperly, and thus redirecting the downloads wasn't working as intended.Fixes #243