Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare the 0.10.5 release #339

Merged
merged 3 commits into from
Jan 13, 2024
Merged

Conversation

benjyw
Copy link
Contributor

@benjyw benjyw commented Dec 22, 2023

No description provided.

kaos
kaos previously approved these changes Dec 22, 2023
@jsirois
Copy link
Contributor

jsirois commented Dec 22, 2023

I suspect this runs afoul of #319 (comment)

Although I submitted a patch to dotenvs here: arniu/dotenvs-rs#5 there has been no activity. I feel good enough about the rules posted by that crate (https://github.com/arniu/dotenvs-rs#parsing-rules) to advertise those rules for scie-jump .env support and depend on my fork. I'll try to get out a scie-jump release today that switches from dotenvy to my fork of dotenvs making this sort of upgrade safer.

@kaos
Copy link
Member

kaos commented Dec 22, 2023

Thanks for jumping in John. I was surprised this wasn't upgraded as I had a vague recollection of seeing a PR about upgrading scie-jump not too long ago. Didn't connect to look for the PR though, my bad.

@kaos kaos self-requested a review December 22, 2023 20:19
@kaos kaos dismissed their stale review December 22, 2023 20:20

Should resolve #319 first.

@jsirois
Copy link
Contributor

jsirois commented Dec 22, 2023

https://github.com/a-scie/jump/releases/tag/v0.14.0 is now released and should allow guilt-free upgrading. It does not address @huonw's request that X=a $Y produce an error, since a shell usually would (if $Y expanded to a non-command). But that request seems a bridge too far to me / has scie-jump nanny on behalf of shell for shell when the .env file may never be sourced anyhow and, if sourced, may even work as intended.

@benjyw
Copy link
Contributor Author

benjyw commented Dec 23, 2023

Bumped to scie-jump 0.14.0, so should be good to go now.

CHANGES.md Show resolved Hide resolved
@huonw
Copy link
Contributor

huonw commented Jan 13, 2024

What's the status of this one @benjyw?

@benjyw
Copy link
Contributor Author

benjyw commented Jan 13, 2024

What's the status of this one @benjyw?

Oops, fell off my radar. I've updated the CHANGES.md per @kaos's suggestion. Will merge when green.

@benjyw benjyw merged commit 6a368c5 into pantsbuild:main Jan 13, 2024
8 checks passed
@benjyw benjyw deleted the prep_0.10.5_release branch January 13, 2024 06:47
huonw added a commit that referenced this pull request Apr 25, 2024
This adds a test to ensure that an invalid `.env` file is detected.

(Replacing #319 after #339.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants