-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install scie-pants in ~/.local/bin
instead of ~/bin
#144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `~/bin` does not follow the XDG based directory spec[1] which recommends `~/.local/bin` and does not offer an `XDG_` env var alternative similar to other paths. [1] https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html
kaos
approved these changes
Nov 7, 2023
Oh joy. looks like I have to change the init action too because not some runner versions are missing |
cognifloyd
added a commit
to pantsbuild/actions
that referenced
this pull request
Nov 7, 2023
Updates to use new version of get-pants.sh from pantsbuild/setup#144
cognifloyd
added a commit
to pantsbuild/pants
that referenced
this pull request
Nov 8, 2023
`get-pants.sh` now installs scie-pants in `~/.local/bin` instead of `~/bin`: pantsbuild/setup#144 This updates the docs to fix that.
cognifloyd
added a commit
to pantsbuild/pants
that referenced
this pull request
Nov 8, 2023
…20155) `get-pants.sh` now installs scie-pants in `~/.local/bin` instead of `~/bin`: pantsbuild/setup#144 This updates the docs to fix that.
cognifloyd
added a commit
to pantsbuild/actions
that referenced
this pull request
Nov 9, 2023
…` instead of `~/bin` (#26) The newest version of `get-pants.sh` uses `~/.local/bin`: pantsbuild/setup#144 This PR has backwards-compatible support for older in-repo copies of the script that still use `~/bin`, but it defaults to the newer `~/.local/bin`.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
~/bin
does not follow the XDG based directory spec which recommends~/.local/bin
and does not offer anXDG_
env var alternative similar to other paths.I first mentioned doing this PR in
pantsbuild/actions#21 (comment)