Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install scie-pants in ~/.local/bin instead of ~/bin #144

Merged
merged 4 commits into from
Nov 7, 2023

Conversation

cognifloyd
Copy link
Member

Using ~/bin does not follow the XDG based directory spec which recommends ~/.local/bin and does not offer an XDG_ env var alternative similar to other paths.

I first mentioned doing this PR in
pantsbuild/actions#21 (comment)

Using `~/bin` does not follow the XDG based directory spec[1] which
recommends `~/.local/bin` and does not offer an `XDG_` env var
alternative similar to other paths.

[1] https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html
@cognifloyd cognifloyd self-assigned this Nov 7, 2023
@cognifloyd
Copy link
Member Author

Oh joy. looks like I have to change the init action too because not some runner versions are missing ~/.local/bin on PATH. Or I have to add the path in this CI workfdlow...

@cognifloyd cognifloyd merged commit 6f13671 into gh-pages Nov 7, 2023
6 checks passed
cognifloyd added a commit to pantsbuild/actions that referenced this pull request Nov 7, 2023
Updates to use new version of get-pants.sh from
pantsbuild/setup#144
@cognifloyd cognifloyd deleted the cognifloyd/local-bin branch November 8, 2023 00:39
cognifloyd added a commit to pantsbuild/pants that referenced this pull request Nov 8, 2023
`get-pants.sh` now installs scie-pants in `~/.local/bin` instead of `~/bin`: pantsbuild/setup#144

This updates the docs to fix that.
cognifloyd added a commit to pantsbuild/pants that referenced this pull request Nov 8, 2023
…20155)

`get-pants.sh` now installs scie-pants in `~/.local/bin` instead of
`~/bin`: pantsbuild/setup#144

This updates the docs to fix that.
cognifloyd added a commit to pantsbuild/actions that referenced this pull request Nov 9, 2023
…` instead of `~/bin` (#26)

The newest version of `get-pants.sh` uses `~/.local/bin`:
pantsbuild/setup#144

This PR has backwards-compatible support for older in-repo copies of the
script that still use `~/bin`, but it defaults to the newer
`~/.local/bin`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants