Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rulesDirectory option of tslint.json not handled correctly #55

Closed
jkillian opened this issue Mar 2, 2016 · 3 comments · Fixed by #63
Closed

rulesDirectory option of tslint.json not handled correctly #55

jkillian opened this issue Mar 2, 2016 · 3 comments · Fixed by #63

Comments

@jkillian
Copy link
Contributor

jkillian commented Mar 2, 2016

gulp-tslint version: 4.3.3
tslint version: 3.5.0
Operating system: All

If a tslint.json file specifies a rulesDirectory property, gulp-tslint needs to resolve those paths relative to the location of the tslint.json file and provide those to TSLint via the rulesDirectory option found here. TSLint has no way of resolving these paths itself since it has no way of knowing where the tslint.json file was located.

This is a subtle bug and I understand that it's not super predictable behavior from TSLint, but I'm now sure what TSLint could do differently. tslint-loader also has a similar bug.

@valorkin
Copy link
Contributor

will be fixed by #63 when merged

@panuhorsmalahti
Copy link
Owner

Hopefully somebody tests that this actually works.

@valorkin
Copy link
Contributor

I am actually using it :)
https://github.com/valor-software/ng2-bootstrap see package.json

On Sun, Apr 24, 2016, 18:55 Panu Horsmalahti notifications@github.com
wrote:

Hopefully somebody tests that this actually works.


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#55 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants