Fix GameScoreboard.date #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was incorrectly offsetting the time when the `game_start_time` was PM. It now parses the time using the `datetime` module's `datetime.strptime` classmethod.
This makes it consistent with my recent GameScoreboard.date change.
|
This is targeted to fix #77. |
This change normalizes a timestamp like "12:40 pm" to "12:40pm". That will ensure it matches the format string when converting to a datetime.
|
Not sure why coverage fell. The lines I changed are covered. |
|
@dowski What does this change do? Why did you have to change the date in the tests? This could cause issues for people if the date has to be changed. |
|
Disregard previous comment as I saw #77. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is right, although I wonder if the timezone that that
game_start_timeis returned in varies based on where you are requesting the data from (using IP geolocation or something?).I also updated the test based on the 7:11PM first pitch time reported in the game box score.