Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/gizmos #46

Merged
merged 12 commits into from
Oct 19, 2023
Merged

Feature/gizmos #46

merged 12 commits into from
Oct 19, 2023

Conversation

kamarianakis
Copy link
Collaborator

Feature: Ability to tab through all visible elements in the scene and manipulate TRS via Unity-like gizmos

Copy link
Collaborator

@aprotopsaltis aprotopsaltis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • translation gizmo delays to follow the mouse
  • achieving rotation was difficult in some cases to grab the rings, also producing some jittery motion in the rings
  • scaling seems to be working on predefined axes. If first rotated and then scaled the issue is visible

Copy link
Collaborator

@aprotopsaltis aprotopsaltis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

additionally the test does not open a window.

@kamarianakis
Copy link
Collaborator Author

  • The rotation has been debugged,
  • The test_gizmos is not supposed to open a window, it contains 5 tests that are in the testing tab, all passing
  • No translation issue on my mac
  • Indeed the scale are currently designed to work in local space, i.e., we do not update the scale gizmo upon rotation of the original object, to allow easier manipulation in 2D (no need to change the camera to properly look for the "hidden" axis

@kamarianakis
Copy link
Collaborator Author

IMHO, this PR is ready to close. If scale should be rotated, we can record it in Issues and add it later on. @aprotopsaltis

@kamarianakis kamarianakis merged commit 526f733 into develop Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants