Restore to working order #2
Conversation
Modify the crop command so it matches the newer sharp API which is them being implemented as options to resize().
| name = 'resize'; | ||
| args = [ null, null, { fit: 'cover', position: args[0] } ]; | ||
|
|
||
| const locatedOperation = locatePreviousCommand(operationsForExecution, name); |
There was a problem hiding this comment.
Since crop and resize are now one and the same, this locatePreviousCommand stuff tries to compact the the commands back together - this can probably be removed for the purposes of removing any chance at functional change.
There was a problem hiding this comment.
Unless it's important for you to maintain backwards compatibility with express-processimage I think we can also just align with the new sharp api? At least if we find it more elegant :)
There was a problem hiding this comment.
Ahhh right yeah - need to remember that this isn’t necessarily meant to abstract the specific engine away but rather select the appropriate engine..
I’ve noticed this elsewhere but there’s obviously a tension between generic commands meaning the right engine is picked for the job versus specific commands that might expose more but tie the choices. My feeling is a handful of generic commands might be useful - particularly setFormat which became a big win in express-processimage but I’ve not thought it through fully.
| let _ = require('lodash'); | ||
| let mime = require('mime'); | ||
| let Pipeline = require('./Pipeline'); | ||
| var _ = require('lodash'); |
There was a problem hiding this comment.
Err, I can return there to being let - that said lebab passes are probably desirable anyway.
There was a problem hiding this comment.
Yeah, lebab ftw. eslint --fix can also take care of many of those, if a good rule set is enabled.
There was a problem hiding this comment.
Oh yeah! My thought was if we land this as-is its be natural to then follow up separately with a prettier conversion and then run the latest eslint over the lot.
This is somewhat of a large PR but it basically upgrades all the modules and puts in some glue to make it compatible with the latest version of
sharp.Oh, just to be transparent it obviously removes the babel build, but this isn't needed at all now that versions of node are out support
async-await. That means as of node 8 all that was needed is swapping a coupe of places back tomodule.exportsand the whole lot goes away making it far easier to build.