Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade eslint-config-prettier to version 6.0.0 #29

Merged
merged 1 commit into from
Jun 28, 2019

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Jun 26, 2019

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ eslint-config-prettier (^5.0.0 → ^6.0.0) · Repo · Changelog

Release Notes

6.0.0 (from changelog)

  • Changed: The CLI helper tool now considers no-confusing-arrow to conflict if you use the default value of its allowParens option. The default was changed to true in ESLint 6, which conflicts with Prettier.

    If the CLI helper tool gives you errors about this after upgrading, the solution is to change this:

    {
      "rules": {
        "no-confusing-arrow": ["error"]
      }
    }

    Into this:

    {
      "rules": {
        "no-confusing-arrow": ["error", { "allowParens": false }]
      }
    }

    The latter works in both ESLint 6 as well as in ESLint 5 and older.

  • Improved: eslint --print-config usage instructions. The CLI tool help text as well as the documentation has been updated to suggest commands that work in ESLint 6.0 as well as in ESLint 5 and older. (Instead of eslint --print-config ., use eslint --print-config path/to/main.js.)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 7 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu label Jun 26, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.566% when pulling 8644832 on depfu/update/npm/eslint-config-prettier-6.0.0 into cd4f563 on master.

@papandreou papandreou merged commit 285f1bc into master Jun 28, 2019
@depfu depfu bot deleted the depfu/update/npm/eslint-config-prettier-6.0.0 branch June 28, 2019 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants