New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup/document altitude definitions: ellipsoid vs. geoid (msl) #1006
Comments
On Thu Dec 04 2014 at 9:40:55 PM Felix Ruess notifications@github.com
|
yes... and your question is? |
On Thu Dec 04 2014 at 10:34:51 PM Felix Ruess notifications@github.com
So why is it wrong to fill it with hmsl?
|
oh, now I see what you mean... sorry... typo... For some conversion chains it still ends up being correct, but that is not generally the case... |
Specifics if all agreed upon will be added to http://wiki.paparazziuav.org/wiki/Demystified/Altitude_and_Height As sideremark for future improvement(rotorcraft - fixedwing unification) |
Does the WGS84 ellipsoid altitude come directly from the GPS or is it On Sat, Dec 6, 2014 at 3:25 PM, OpenUAS notifications@github.com wrote:
|
Ellipsoid altitude is computed in paparazzi (e.g. when converting from ECEF to LLA, see lla_of_ecef_d function). |
Thanks Felix, Does this mean that the altitude in the DC_SHOT message is computed by On Sat, Dec 6, 2014 at 6:56 PM, Felix Ruess notifications@github.com
|
The LLA position is fetched from the state interface with |
Do we need to keep this open? At least the current state is documented... |
I think ellipsoid / geoid is quite clear.
This issue can be closed, but at some point an update an update in the class Altitude } -Christophe On Tue, Nov 3, 2015 at 10:33 PM, Felix Ruess notifications@github.com
|
I am a bit confused with the utm alt... in the definition of the struct it states "in meters above WGS84 reference ellipsoid" but in state.c, the reference frame is set using hmsl (void ins_float_invariant_init(void):216). Shouldn't we just stick to one? The two are quite confusing. |
@kirkscheper maybe we shouldn't specify the alt reference in the |
If it isn't consistently used, it may be more clear not to have a height in that structure at all, haha. Users would have to get the altitude from another place (lla for above ellipsoid, ins for ground, gps for geoid). Or alternatively... store the height somewhere readily available in each format (if available) in the state.c using a similar bit set method used for the other formats. |
There is no simple solution for this... sometimes you simply need ellipsoid alt (e.g. converting to ECEF) and sometimes geoid/msl alt. And you don't always have information for both ellipsoid and geoid. |
:'( On 22/03/16 12:54, Felix Ruess wrote:
|
Currently we are mixing up different altitude definitions in some cases/messages which clearly needs to be consolidated, cleaned up and documented.
We usually have global altitude as either
See also differences explained at https://wiki.paparazziuav.org/wiki/Altitude_definitions
Some things to check/fix/consolidate/document:
LtpDef has alt above ellipsoid in LLA coordinates and an addtional hmsl field
The text was updated successfully, but these errors were encountered: